util: Remove BuildGitInfo #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have other ways of determining the version at runtime (namely: the tag associated with the images), and this just adds needless complication to our dockerfiles.
| // See also: | ||
| // https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set | ||
| LabelPluginCreatedMigration: gitVersion, | ||
| LabelPluginCreatedMigration: "true", |
There was a problem hiding this comment.
is it okay that the format of the label value has changed?
There was a problem hiding this comment.
Yup -- double-checked that the only place we use this label is here:
autoscaling/pkg/plugin/watch.go
Lines 362 to 369 in 4156e39
... where we don't require that it's set to any particular value :)
mikhail-sakhnov
approved these changes
Oct 14, 2024
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. HTML Report |
sharnoff
added a commit
that referenced
this pull request
Dec 10, 2024
Follow-up to #1109, must have forgotten it there. These are no longer used.
sharnoff
added a commit
that referenced
this pull request
Dec 12, 2024
Follow-up to #1109, must have forgotten it there. These are no longer used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have other ways of determining the version at runtime (namely: the tag associated with the images), and this just adds needless complication to our dockerfiles.