util: Remove BuildGitInfo

autoscale-scheduler/Dockerfile

@@ -6,9 +6,7 @@ ARG GIT_INFO
 COPY . .
 # NOTE: Build flags here must be the same as in the base image, otherwise we'll rebuild
 # dependencies. See /Dockerfile.go-base for detail on the "why".
-RUN CGO_ENABLED=0 go build \
-    -ldflags "-X 'github.com/neondatabase/autoscaling/pkg/util.BuildGitInfo=$GIT_INFO'" \
-    autoscale-scheduler/cmd/*.go
+RUN CGO_ENABLED=0 go build autoscale-scheduler/cmd/*.go
 
 FROM alpine:3.19
 COPY --from=builder /workspace/main /usr/bin/kube-scheduler

autoscale-scheduler/cmd/main.go

@@ -26,7 +26,6 @@ func main() {
 	logConfig := zap.NewProductionConfig()
 	logConfig.Sampling = nil // Disable sampling, which the production config enables by default.
 	logger := zap.Must(logConfig.Build()).Named("autoscale-scheduler")
-	logger.Info("", zap.Any("buildInfo", util.GetBuildInfo()))
 
 	if err := runProgram(logger); err != nil {
 		log.Fatal(err)

autoscaler-agent/Dockerfile

@@ -6,9 +6,7 @@ ARG GIT_INFO
 COPY . .
 # NOTE: Build env vars here must be the same as in the base image, otherwise we'll rebuild
 # dependencies.
-RUN CGO_ENABLED=0 go build \
-    -ldflags "-X 'github.com/neondatabase/autoscaling/pkg/util.BuildGitInfo=$GIT_INFO'" \
-    autoscaler-agent/cmd/*.go
+RUN CGO_ENABLED=0 go build autoscaler-agent/cmd/*.go
 
 FROM alpine:3.19
 COPY --from=builder /workspace/main /usr/bin/autoscaler-agent

autoscaler-agent/cmd/main.go

@@ -26,8 +26,6 @@ func main() {
 	logger := zap.Must(logConfig.Build()).Named("autoscaler-agent")
 	defer logger.Sync() //nolint:errcheck // what are we gonna do, log something about it?
 
-	logger.Info("", zap.Any("buildInfo", util.GetBuildInfo()))
-
 	envArgs, err := agent.ArgsFromEnv()
 	if err != nil {
 		logger.Panic("Failed to get args from environment", zap.Error(err))

pkg/agent/dumpstate.go

@@ -19,9 +19,8 @@ import (
 )
 
 type StateDump struct {
-	Stopped   bool           `json:"stopped"`
-	BuildInfo util.BuildInfo `json:"buildInfo"`
-	Pods      []podStateDump `json:"pods"`
+	Stopped bool           `json:"stopped"`
+	Pods    []podStateDump `json:"pods"`
 }
 
 func (s *agentState) StartDumpStateServer(shutdownCtx context.Context, logger *zap.Logger, config *DumpStateConfig) error {
@@ -85,9 +84,8 @@ func (s *agentState) DumpState(ctx context.Context, stopped bool) (*StateDump, e
 	}
 
 	state := StateDump{
-		Stopped:   stopped,
-		BuildInfo: util.GetBuildInfo(),
-		Pods:      make([]podStateDump, len(podList)),
+		Stopped: stopped,
+		Pods:    make([]podStateDump, len(podList)),
 	}
 
 	wg := sync.WaitGroup{}

pkg/plugin/dumpstate.go

@@ -33,9 +33,8 @@ func (c *dumpStateConfig) validate() (string, error) {
 }
 
 type stateDump struct {
-	Stopped   bool            `json:"stopped"`
-	BuildInfo util.BuildInfo  `json:"buildInfo"`
-	State     pluginStateDump `json:"state"`
+	Stopped bool            `json:"stopped"`
+	State   pluginStateDump `json:"state"`
 }
 
 func (p *AutoscaleEnforcer) startDumpStateServer(shutdownCtx context.Context, logger *zap.Logger) error {
@@ -87,9 +86,8 @@ func (p *AutoscaleEnforcer) dumpState(ctx context.Context, stopped bool) (*state
 	}
 
 	return &stateDump{
-		Stopped:   stopped,
-		BuildInfo: util.GetBuildInfo(),
-		State:     *state,
+		Stopped: stopped,
+		State:   *state,
 	}, nil
 }
 

pkg/plugin/state.go

@@ -1234,25 +1234,14 @@ func (e *AutoscaleEnforcer) startMigration(ctx context.Context, logger *zap.Logg
 		return false, fmt.Errorf("Error checking if migration exists: %w", err)
 	}
 
-	gitVersion := util.GetBuildInfo().GitInfo
-	// FIXME: make this not depend on GetBuildInfo() internals.
-	if gitVersion == "<unknown>" {
-		gitVersion = "unknown"
-	}
-
 	vmm := &vmapi.VirtualMachineMigration{
 		ObjectMeta: metav1.ObjectMeta{
 			// TODO: it's maybe possible for this to run into name length limits? Unclear what we
 			// should do if that happens.
 			Name:      vmmName.Name,
 			Namespace: pod.name.Namespace,
 			Labels: map[string]string{
-				// NB: There's requirements on what constitutes a valid label. Thankfully, the
-				// output of `git describe` always will.
-				//
-				// See also:
-				// https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set
-				LabelPluginCreatedMigration: gitVersion,
+				LabelPluginCreatedMigration: "true",
 			},
 		},
 		Spec: vmapi.VirtualMachineMigrationSpec{