Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release workflow #9

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Add release workflow #9

merged 3 commits into from
Jan 12, 2023

Conversation

sharnoff
Copy link
Member

@sharnoff sharnoff commented Jan 9, 2023

Closes #6, adapted from NeonVM's workflow as suggested.

Renamed a couple files in deploy/, which required renaming in files unrelated to this PR.

Remaining items:

Open questions:

  • Should we build (and push?) an image for the vm-informant binary? We need a dockerfile for it anyways (used in vm_image/Dockerfile.vmdata), but an image for it probably won't be used outside of development. cc @kelvich - thoughts?
  • With the added ability to expose secrets via push + tag, do we need to protect the main branch and require review for PRs? Requiring review would be inconvenient for me, but I understand the security argument.

Follow-up work:

  • neondatabase/neon: Include vm-informant binaries in compute images

@sharnoff sharnoff requested a review from cicdteam January 9, 2023 22:29
@sharnoff sharnoff force-pushed the sharnoff/release-workflow branch from 47631e2 to 4a5914f Compare January 11, 2023 00:34
@sharnoff sharnoff marked this pull request as ready for review January 11, 2023 00:55
Bit of a hack, but that's ok for now. We can switch to properly using
kustomize as a separate PR.
@sharnoff sharnoff force-pushed the sharnoff/release-workflow branch from 678c736 to f5e24b0 Compare January 11, 2023 01:11
@cicdteam
Copy link
Contributor

cicdteam commented Jan 11, 2023

@sharnoff
I see only two secrets used in GHA (NEON_DOCKERHUB_USERNAME and NEON_DOCKERHUB_PASSWORD) and they are org wide, so need no set them in repo settings

@sharnoff
Copy link
Member Author

@cicdteam ah wonderful - thanks!

@sharnoff
Copy link
Member Author

Merging this as-is, planning on fixing workflow issues as they come up. Record of decision-making:

  • Stick with Dockerhub (instead of ECR) because it was easier to adapt other examples of our workflows using it. The images are just alpine + final binary, so it's mostly ok either way, but it's always possible to move from Dockerhub -> ECR
  • Push vm-informant images anyways (per discussion with @stas) — basically it doesn't matter either way, might as well go for it
  • Potential concern about unprotected branch + ability to access secrets unaddressed, merging anyways. If it's still a concern, we can fix it afterwards

@sharnoff sharnoff merged commit 6bff7f4 into main Jan 12, 2023
@sharnoff sharnoff deleted the sharnoff/release-workflow branch January 16, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup release pipeline
2 participants