Use updated patched azure SDK crates #10036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradludgate
approved these changes
Dec 6, 2024
7040 tests run: 6731 passed, 0 failed, 309 skipped (full report)Flaky tests (5)Postgres 17
Postgres 16
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
1920b6e at 2024-12-06T15:00:10.171Z :recycle: |
VladLazar
approved these changes
Dec 9, 2024
|
The slack thread is in https://neondb.slack.com/archives/C0277TKAJCA/p1733351609298809 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while already, we've been unable to update the Azure SDK crates due to Azure adopting use of a non-tokio async runtime, see #7545.
The effort to upstream the fix got stalled, and I think it's better to switch to a patched version of the SDK that is up to date.
Now we have a fork of the SDK under the neondatabase github org, to which I have applied Conrad's rebased patches to: https://github.com/neondatabase/azure-sdk-for-rust/tree/neon .
The existence of a fork will also help with shipping bulk delete support before it's upstreamed (#7931).
Also, in related news, the Azure SDK has gotten a rift in development, where the main branch pertains to a future, to-be-officially-blessed release of the SDK, and the older versions, which we are currently using, are on the
legacybranch. Upstream doesn't really want patches for thelegacybranch any more, they want to focus on themainefforts. However, even then, thelegacybranch is still newer than what we are having right now, so let's switch tolegacyfor now.Depending on how long it takes, we can switch to the official version of the SDK once it's released or switch to the upstream
mainbranch if there is changes we want before that.As a nice side effect of this PR, we now use reqwest 0.12 everywhere, dropping the dependency on version 0.11.
Fixes #7545