refactor: globals in tests #5298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
commented
Sep 13, 2023
koivunej
commented
Sep 13, 2023
2472 tests run: 2352 passed, 0 failed, 120 skipped (full report)Flaky tests (6)Postgres 16
Postgres 14Code coverage (full report)
The comment gets automatically updated with the latest test results
639b243 at 2023-09-13T18:38:45.575Z :recycle: |
This commit reverts 0c68972 Co-authored-by: Matthias <[email protected]>
bayandin
force-pushed
the
refactor_consumption_metrics_test_1
branch
from
cb36f41 to
520024a
Compare
Co-authored-by: Joonas Koivunen <[email protected]>
|
Oh nice, only these failures. |
koivunej
changed the title
koivunej
added a commit
that referenced
this pull request
Sep 28, 2023
Part of #5172. Builds upon #5243, #5298. Includes the test changes: - no more RemoteStorageKind.NOOP - no more testing of pageserver without remote storage - benchmarks now use LOCAL_FS as well Support for running without RemoteStorage is still kept but in practice, there are no tests and should not be any tests. Co-authored-by: Christian Schwarz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor tests to have less globals.
This will allow to hopefully write more complex tests for our new metric collection requirements in #5297. Includes reverted work from #4761 related to test globals.