ongoing: fix: consumption metrics on restart #5297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
force-pushed
the
refactor_consumption_metrics_test
branch
from
24d8eef to
4babbc4
Compare
koivunej
added a commit
that referenced
this pull request
Sep 13, 2023
Refactor tests to have less globals. This will allow to hopefully write more complex tests for our new metric collection requirements in #5297. Includes reverted work from #4761 related to test globals. Co-authored-by: Alexander Bayandin <[email protected]> Co-authored-by: MMeent <[email protected]>
koivunej
force-pushed
the
refactor_consumption_metrics_test
branch
2 times, most recently
from
22ec922 to
45c76d2
Compare
2472 tests run: 2353 passed, 1 failed, 118 skipped (full report)Failures on Postgres 14
Flaky tests (2)Postgres 16
Postgres 14
Test coverage report is not availableThe comment gets automatically updated with the latest test results
badfa15 at 2023-09-15T14:03:58.876Z :recycle: |
we no longer should be using it anywhere
fix one bug.
the extra timeline without an endpoint was causing the 10s delay to kick in.
arpad-m
reviewed
Sep 15, 2023
This was referenced Sep 15, 2023
koivunej
added a commit
that referenced
this pull request
Sep 15, 2023
Split off from #5297. There should be no functional changes here: - refactor tenant metric "production" like previously timeline, allows unit testing, though not interesting enough yet to test - introduce type aliases for tuples - extra refactoring for `collect`, was initially thinking it was useful but will do a inline later - shorter binding names - support for future allocation reuse quests with IdempotencyKey - move code out of tokio::select to make it rustfmt-able - generification, allow later replacement of `&'static str` with enum - add tests that assert sent event contents exactly
koivunej
added a commit
that referenced
this pull request
Sep 15, 2023
koivunej
added a commit
that referenced
this pull request
Sep 15, 2023
koivunej
changed the title
This was referenced Sep 16, 2023
|
This is no longer needed. |
koivunej
added a commit
that referenced
this pull request
Sep 16, 2023
koivunej
added a commit
that referenced
this pull request
Sep 16, 2023
koivunej
added a commit
that referenced
this pull request
Sep 18, 2023
Split off from #5297. Builds upon #5326. Handles original review comments which I did not move to earlier split PRs. Completes test support for verifying events by notifying of the last batch of events. Adds cleaning up of tempfiles left because of an unlucky shutdown or SIGKILL. Finally closes #5175. Co-authored-by: Arpad Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes: #5206
Fixes: #5175
Split off: #5298, #5315, #5316, #5317, #5323, #5324, #5325, #5326, #5327
Summary of changes
(earlier have been split off)