refactor(consumption_metrics): split #5326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
requested review from
save-buffer and
problame
and removed request for
a team
koivunej
force-pushed
the
refactor_consumption_metrics_test_7
branch
from
d1d23bb to
7f8b78e
Compare
koivunej
force-pushed
the
refactor_consumption_metrics_test_8
branch
from
bdfe3d6 to
d1d23bb
Compare
koivunej
changed the title
This was referenced Sep 16, 2023
2484 tests run: 2363 passed, 0 failed, 121 skipped (full report)Flaky tests (2)Postgres 15
Postgres 14
Code coverage (full report)
The comment gets automatically updated with the latest test results
b92335c at 2023-09-16T15:49:18.462Z :recycle: |
arpad-m
approved these changes
Sep 16, 2023
Base automatically changed from
refactor_consumption_metrics_test_7
to
main
September 16, 2023 15:08
koivunej
added a commit
that referenced
this pull request
Sep 16, 2023
koivunej
force-pushed
the
refactor_consumption_metrics_test_8
branch
from
d1d23bb to
b92335c
Compare
koivunej
added a commit
that referenced
this pull request
Sep 18, 2023
Split off from #5297. Builds upon #5326. Handles original review comments which I did not move to earlier split PRs. Completes test support for verifying events by notifying of the last batch of events. Adds cleaning up of tempfiles left because of an unlucky shutdown or SIGKILL. Finally closes #5175. Co-authored-by: Arpad Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #5297. Builds upon #5325, should contain only the splitting. Next up: #5327.