Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consumption_metrics): exp backoff retry #5317

Merged
merged 11 commits into from
Sep 15, 2023

Conversation

koivunej
Copy link
Member

Split off from #5297. Depends on #5315.
Cc: #5175 for retry

@koivunej koivunej requested review from jcsp and arpad-m September 15, 2023 14:07
@koivunej koivunej requested review from a team as code owners September 15, 2023 14:08
@koivunej koivunej requested review from knizhnik and problame and removed request for a team September 15, 2023 14:08
@koivunej koivunej changed the title fix: proper exp backoff retry fix(consumption_metrics): exp backoff retry Sep 15, 2023
pageserver/src/consumption_metrics.rs Show resolved Hide resolved
pageserver/src/consumption_metrics.rs Outdated Show resolved Hide resolved
pageserver/src/consumption_metrics.rs Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 15, 2023

2484 tests run: 2362 passed, 0 failed, 122 skipped (full report)


Flaky tests (6)

Postgres 16

  • test_partial_evict_tenant: debug, release
  • test_get_tenant_size_with_multiple_branches: release

Postgres 14

  • test_download_remote_layers_api[local_fs]: debug
  • test_get_tenant_size_with_multiple_branches: release, debug

Code coverage (full report)

  • functions: 53.1% (7697 of 14507 functions)
  • lines: 81.0% (44971 of 55535 lines)

The comment gets automatically updated with the latest test results
3a75580 at 2023-09-15T22:18:09.185Z :recycle:

@koivunej koivunej force-pushed the refactor_consumption_metrics_test_4 branch from dbdab18 to ae9e81c Compare September 15, 2023 15:11
Base automatically changed from refactor_consumption_metrics_test_2 to main September 15, 2023 16:44
@vipvap vipvap requested a review from a team as a code owner September 15, 2023 16:44
@koivunej koivunej force-pushed the refactor_consumption_metrics_test_4 branch from 8267796 to 77627c3 Compare September 15, 2023 19:32
@arpad-m
Copy link
Member

arpad-m commented Sep 15, 2023

Test failure looks legit:

__________________ test_threshold_based_eviction[debug-pg14] ___________________
[gw9] linux -- Python 3.9.2 /github/home/.cache/pypoetry/virtualenvs/neon-_pxWMzVK-py3.9/bin/python
test_runner/regress/test_threshold_based_eviction.py:180: in test_threshold_based_eviction
    assert env.pageserver.log_contains(
E   AssertionError: ensure the metrics collection worker ran
E   assert None

@arpad-m
Copy link
Member

arpad-m commented Sep 15, 2023

This one I saw multiple times:

[gw2] linux -- Python 3.9.2 /github/home/.cache/pypoetry/virtualenvs/neon-_pxWMzVK-py3.9/bin/python
test_runner/regress/test_threshold_based_eviction.py:180: in test_threshold_based_eviction
    assert env.pageserver.log_contains(
E   AssertionError: ensure the metrics collection worker ran
E   assert None

Even before your force push, all the regression test jobs failed. now they did it again. This is not how flukes look like.

@koivunej koivunej force-pushed the refactor_consumption_metrics_test_4 branch from 77627c3 to 323a301 Compare September 15, 2023 21:07
@koivunej
Copy link
Member Author

koivunej commented Sep 15, 2023

Thanks, I must've forgotten to cherry-pick some.

No, I did remember it (was already before latest force-push): 7fdaff8. Aah, the middle span is not yet in place...

@koivunej
Copy link
Member Author

test_download_remote_layers_api[debug-pg14-local_fs]
test_partial_evict_tenant[release-pg16]

oh nice, it's partial_evict_tenant again. Trying the first one over at #5322.

@koivunej koivunej merged commit a7f4ee0 into main Sep 15, 2023
@koivunej koivunej deleted the refactor_consumption_metrics_test_4 branch September 15, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants