Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(consumption_metrics): prereq refactorings, tests #5315

Merged
merged 14 commits into from
Sep 15, 2023

Conversation

koivunej
Copy link
Member

@koivunej koivunej commented Sep 15, 2023

Split off from #5297.

There should be no functional changes here:

  • refactor tenant metric "production" like previously timeline, allows unit testing, though not interesting enough yet to test
  • introduce type aliases for tuples
  • extra refactoring for collect, was initially thinking it was useful but will do a inline later
  • shorter binding names
  • support for future allocation reuse quests with IdempotencyKey
  • move code out of tokio::select to make it rustfmt-able
  • generification, allow later replacement of &'static str with enum
  • add tests that assert sent event contents exactly

Next up are two non-conflicting:

@koivunej koivunej requested review from jcsp and arpad-m September 15, 2023 14:03
@koivunej koivunej requested review from a team as code owners September 15, 2023 14:03
@koivunej koivunej requested review from conradludgate and shanyp and removed request for a team September 15, 2023 14:03
@koivunej koivunej enabled auto-merge (squash) September 15, 2023 14:35
@koivunej koivunej changed the title Minor consumption metrics related refactorings refactor(consumption_metrics): prereq refactorings, tests Sep 15, 2023
@koivunej koivunej disabled auto-merge September 15, 2023 14:37
@koivunej koivunej enabled auto-merge (squash) September 15, 2023 14:37
@github-actions
Copy link

2478 tests run: 2357 passed, 0 failed, 121 skipped (full report)


Flaky tests (4)

Postgres 16

  • test_crafted_wal_end[last_wal_record_crossing_segment]: release

Postgres 14

  • test_download_remote_layers_api[local_fs]: debug, release
  • test_get_tenant_size_with_multiple_branches: release

Code coverage (full report)

  • functions: 53.0% (7673 of 14483 functions)
  • lines: 81.0% (44856 of 55401 lines)

The comment gets automatically updated with the latest test results
733e572 at 2023-09-15T15:08:30.492Z :recycle:

@koivunej koivunej merged commit c5d226d into main Sep 15, 2023
@koivunej koivunej deleted the refactor_consumption_metrics_test_2 branch September 15, 2023 16:44
koivunej added a commit that referenced this pull request Sep 15, 2023
Split off from #5297. Depends on #5315.
Cc: #5175 for retry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants