Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(consumption_metrics): remove event deduplication support #5316

Merged
merged 2 commits into from
Sep 15, 2023
Merged

feat(consumption_metrics): remove event deduplication support #5316

merged 2 commits into from
Sep 15, 2023

Conversation

koivunej
Copy link
Member

@koivunej koivunej commented Sep 15, 2023 •
edited
Loading

We no longer use pageserver deduplication anywhere. Give out a warning instead.

Split off from #5297.

Cc: #5175 for dedup.

@koivunej koivunej requested review from jcsp and arpad-m September 15, 2023 14:06
@koivunej koivunej requested review from a team as code owners September 15, 2023 14:06
@koivunej koivunej requested review from save-buffer and hlinnaka and removed request for a team September 15, 2023 14:06
@koivunej koivunej mentioned this pull request Sep 15, 2023
Merged
@koivunej koivunej changed the title feat: remove ability to deduplicate events feat(consumption_metrics): remove ability to deduplicate events Sep 15, 2023
@koivunej koivunej mentioned this pull request Sep 15, 2023
Closed
@koivunej koivunej changed the title feat(consumption_metrics): remove ability to deduplicate events feat(consumption_metrics): remove event deduplication support Sep 15, 2023
@github-actions
Copy link

github-actions bot commented Sep 15, 2023 •
edited
Loading

2484 tests run: 2363 passed, 0 failed, 121 skipped (full report)

Flaky tests (3)

Postgres 16

Postgres 14

  • test_download_remote_layers_api[local_fs]: debug
  • test_get_tenant_size_with_multiple_branches: release

Code coverage (full report)

  • functions: 53.0% (7680 of 14491 functions)
  • lines: 80.9% (44905 of 55475 lines)
The comment gets automatically updated with the latest test results
ddf4796 at 2023-09-15T21:05:33.846Z :recycle:

@koivunej
Copy link
Member Author

koivunej commented Sep 15, 2023 •
edited
Loading

Ah, this needs a test fix default value change from the ongoing branch.

Base automatically changed from refactor_consumption_metrics_test_2 to main September 15, 2023 16:44
@vipvap vipvap requested a review from a team as a code owner September 15, 2023 16:44
@koivunej koivunej force-pushed the refactor_consumption_metrics_test_3 branch from bf1d93c to ddf4796 Compare September 15, 2023 19:31
@koivunej koivunej enabled auto-merge (squash) September 15, 2023 19:43
@koivunej koivunej disabled auto-merge September 15, 2023 20:45
@koivunej koivunej mentioned this pull request Sep 15, 2023
Closed
@koivunej koivunej merged commit 00c4c8e into main Sep 15, 2023
@koivunej koivunej deleted the refactor_consumption_metrics_test_3 branch September 15, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpad-m arpad-m arpad-m approved these changes

@jcsp jcsp Awaiting requested review from jcsp

@save-buffer save-buffer Awaiting requested review from save-buffer save-buffer was automatically assigned from neondatabase/compute

@hlinnaka hlinnaka Awaiting requested review from hlinnaka hlinnaka is a code owner automatically assigned from neondatabase/storage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koivunej @arpad-m