-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: consumption metrics on restart #5323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix one bug.
the extra timeline without an endpoint was causing the 10s delay to kick in.
koivunej
force-pushed
the
refactor_consumption_metrics_test_5
branch
from
September 15, 2023 23:01
77cc4fe
to
1579f69
Compare
koivunej
requested review from
bojanserafimov and
shanyp
and removed request for
a team
September 15, 2023 23:34
2484 tests run: 2362 passed, 0 failed, 122 skipped (full report)Code coverage (full report)
The comment gets automatically updated with the latest test results
875e219 at 2023-09-15T23:44:50.469Z :recycle: |
arpad-m
reviewed
Sep 16, 2023
arpad-m
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5206
Cc: #5175 (loggings, will be enhanced in follow-up)
Write collected metrics to disk to recover previously sent metrics on restart.
Recover the previously collected metrics during startup, send them over at right time
last_record_lsn
rolls back on startupwritten_size
metricwritten_size_delta_bytes
metric as 0Add test support: stateful verification of events in python tests.