chore(proxy): enforce single host+port #9995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awarus
approved these changes
Dec 3, 2024
7018 tests run: 6710 passed, 0 failed, 308 skipped (full report)Flaky tests (2)Postgres 17
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
0da5564 at 2024-12-03T20:05:55.999Z :recycle: |
conradludgate
force-pushed
the
conrad/enforce-single-host-port
branch
from
b47e96a to
0da5564
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
(stacked on #9990 and #9995) Partially fixes #1287 with a custom option field to enable the fixed behaviour. This allows us to gradually roll out the fix without silently changing the observed behaviour for our customers. related to neondatabase/cloud#15284
awarus
pushed a commit
that referenced
this pull request
Dec 5, 2024
proxy doesn't ever provide multiple hosts/ports, so this code adds a lot of complexity of error handling for no good reason. (stacked on #9990)
awarus
pushed a commit
that referenced
this pull request
Dec 5, 2024
(stacked on #9990 and #9995) Partially fixes #1287 with a custom option field to enable the fixed behaviour. This allows us to gradually roll out the fix without silently changing the observed behaviour for our customers. related to neondatabase/cloud#15284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proxy doesn't ever provide multiple hosts/ports, so this code adds a lot of complexity of error handling for no good reason.
(stacked on #9990)