Add pyproject.toml build system #364
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 22, 2024 15:46
| @@ -0,0 +1,3 @@ | |||
| [build-system] | |||
| # Minimum requirements for the build system to execute. | |||
| requires = ["setuptools", "wheel", "torch", "numpy==1.26.4"] # PEP 508 specifications. | |||
There was a problem hiding this comment.
I guess pip install . would trigger this, is that true? Would this get triggered if I run python setup.py?
Also numpy==1.26.4 seems too constrained than necessary. We probably don't need to specify numpy version for the gsplat library?
|
Btw, I think the requirements are already there: Lines 130 to 137 in 507f26e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying to address issue #363