Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml build system #364

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add pyproject.toml build system #364

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f12e781
testing
Aug 22, 2024
b059f28
adding pyproject.toml with build-system
Aug 22, 2024
98d1391
cleaning PR
Aug 23, 2024
58af240
Revert "cleaning PR"
Aug 23, 2024
b07fcb0
cleaning PR
Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[build-system]
# Minimum requirements for the build system to execute.
requires = ["setuptools", "wheel", "torch", "numpy==1.26.4"] # PEP 508 specifications.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess pip install . would trigger this, is that true? Would this get triggered if I run python setup.py?

Also numpy==1.26.4 seems too constrained than necessary. We probably don't need to specify numpy version for the gsplat library?