Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

float3 fix #44

Merged
merged 1 commit into from
Oct 13, 2023
Merged

float3 fix #44

merged 1 commit into from
Oct 13, 2023

Conversation

liruilong940607
Copy link
Collaborator

fix the compiling error on windows:

D:\a\gsplat\gsplat\gsplat\cuda\csrc\forward.cu(666): error: expected an expression

Also temporarily change workflow to windows compiling only for debugging

maturk
maturk approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@maturk maturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets try it

@maturk maturk merged commit 1e64d1c into main Oct 13, 2023
2 checks passed
@liruilong940607 liruilong940607 mentioned this pull request Oct 13, 2023
Merged
kerrj pushed a commit that referenced this pull request Nov 1, 2023
@liruilong940607
float3 fix (#44)
c7c7ad2 
Co-authored-by: Ruilong Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maturk maturk maturk approved these changes

@vye16 vye16 Awaiting requested review from vye16

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liruilong940607 @maturk