Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize DECREF (MPI edition). #3207

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Modernize DECREF (MPI edition). #3207

merged 3 commits into from
Nov 21, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Nov 14, 2024

No description provided.

@1uc 1uc changed the base branch from master to 1uc/modernize-decref-3 November 14, 2024 10:08
@1uc 1uc force-pushed the 1uc/modernize-decref-debug branch from b8ebf71 to 71bb637 Compare November 14, 2024 10:09
Copy link

✔️ 71bb637 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Base automatically changed from 1uc/modernize-decref-3 to master November 18, 2024 07:28
@1uc 1uc force-pushed the 1uc/modernize-decref-debug branch from 71bb637 to 404da68 Compare November 20, 2024 08:21
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.07%. Comparing base (a8b882b) to head (2f40a23).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/nrnpython/nrnpy_p2h.cpp 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3207   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files         569      569           
  Lines      111146   111144    -2     
=======================================
- Hits        74552    74551    -1     
+ Misses      36594    36593    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@1uc 1uc force-pushed the 1uc/modernize-decref-debug branch 2 times, most recently from ee016d2 to 4ce0380 Compare November 20, 2024 09:12
@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 4ce0380 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ e83b877 -> Azure artifacts URL

@1uc 1uc marked this pull request as ready for review November 20, 2024 14:19
@1uc 1uc mentioned this pull request Nov 20, 2024
@1uc 1uc force-pushed the 1uc/modernize-decref-debug branch from e83b877 to 2f40a23 Compare November 21, 2024 07:44
Copy link

sonarcloud bot commented Nov 21, 2024

Copy link

✔️ 2f40a23 -> Azure artifacts URL

@1uc 1uc merged commit d910b74 into master Nov 21, 2024
35 checks passed
@1uc 1uc deleted the 1uc/modernize-decref-debug branch November 21, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants