Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the notifications area width equal to the contents #10881

Merged
merged 1 commit into from
Aug 28, 2018

Conversation

weeman1337
Copy link
Member

closes #10705

@weeman1337 weeman1337 added design Design, UI, UX, etc. 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. labels Aug 27, 2018
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Works like a charm. 👍

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it uses the standard of the .menu behaviour?
I cannot test right now. @juliushaertl ?

@juliusknorr
Copy link
Member

@skjnldsv Do you mean to show them in a popover menu? Not sure if I get you correct there.

@skjnldsv
Copy link
Member

@juliushaertl this or touches the notification area in the header right?
If so we should make sure to use the mobile menu header standard we use for the other menus, right?

@juliusknorr
Copy link
Member

@skjnldsv Not sure about adding them to the notifications area, since those are rather temporary notifications, but yes, we should improve the rendering for that. There already was an issue about that but I cannot find it right now. However I'd still just get this into 14 and improve the general rendering later.

@weeman1337
Copy link
Member Author

@skjnldsv this just changes, that the notifications take the full width (see issue #10705). It doesn't change any behavior or rendering.

@skjnldsv skjnldsv merged commit a3d61b4 into master Aug 28, 2018
@skjnldsv
Copy link
Member

@weeman1337 sorry, I was reading on my mobile, I mistaken the code for something else :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The notification container partially overlapping the header bar actions
4 participants