Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libgomp1 for running FastTree #126

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Dec 23, 2022

Description of proposed changes

As far as I can tell from the official software page¹, no dependencies are documented.

However, there are (unofficial?) Linux packages²³ that list libc6 and libgomp1 as dependencies. Adding the latter for now since augur tree --method fasttree fails with the error:

FastTreeDblMP: error while loading shared libraries: libgomp.so.1: cannot open shared object file: No such file or directory

¹ http://www.microbesonline.org/fasttree/
² https://packages.ubuntu.com/focal/fasttree
³ https://packages.debian.org/sid/science/fasttree

Related issue(s)

Testing

  • Checks pass
  • docker run nextstrain/base:branch-victorlin-fix-fasttree FastTreeDblMP -h shows the help output instead of the error in the original issue.

As far as I can tell from the official software page¹, no dependencies
are documented.

However, there are (unofficial?) Linux packages²³ that list libc6 and
libgomp1 as dependencies. Adding the latter for now since `augur tree
--method fasttree` fails with the error:

    FastTreeDblMP: error while loading shared libraries: libgomp.so.1: cannot open shared object file: No such file or directory

¹ http://www.microbesonline.org/fasttree/
² https://packages.ubuntu.com/focal/fasttree
³ https://packages.debian.org/sid/science/fasttree
@victorlin victorlin self-assigned this Dec 23, 2022
@victorlin victorlin marked this pull request as ready for review December 23, 2022 15:21
@victorlin victorlin requested a review from a team December 23, 2022 15:21
@victorlin
Copy link
Member Author

Merging without review since this is a small change and testing was successful.

@victorlin victorlin merged commit 3ab045e into master Dec 23, 2022
@victorlin victorlin deleted the victorlin/fix-fasttree branch December 23, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FastTreeDblMP doesn't work in docker
1 participant