-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data format: TSV #238
Data format: TSV #238
Conversation
Preparing to add a separate section for TSV files.
Proper handling of TSVs with `csvtk`/`tsv-utils` was originally recommended by @tsibley <nextstrain/augur#1566 (comment)>
Hmm, both rtd redirects and docs build failed with 403 Client Error...maybe related to readthedocs/readthedocs.org#11763. |
Adding User-Agent as an attempt to fix the 403 Client Errors returned from requests to GitHub.
Hooray, c561b61 seems to fix the docs build. Looking into rtd redirects, which I believe will require updating/releasing https://github.com/nextstrain/readthedocs-cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from me; the "be more definitive" comment is not a blocker, just a suggestion.
Created issue to track rtd redirect error, but that should not block this PR since I'm not making any changes to the redirect paths: docs.nextstrain.org/.github/workflows/sync-redirects.yaml Lines 7 to 9 in a15d2ab
|
Recommended by @genehack in review <#238 (comment)>
Is this the correct place to document suggested python code for reading/writing? Would be great to have snippets to reuse |
Ah, that's true! I'll add it tomorrow. |
Prompted by @jameshadfield's request <#238 (comment)> Snippets are simplified versions of TSV handling in Augur.
Prompted by @jameshadfield's request <#238 (comment)> Snippets are simplified versions of TSV handling in Augur.
docs preview
Description of proposed changes
Add TSV section to the Data Format docs, based on discussion in nextstrain/augur#1566.
Related issue(s)
Resolves #237
Checklist