-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ingest #7
Conversation
@genehack did you name this PR |
thanks, no, not intentionally, my brain gest 😁 really wants that soft g to be a j ... |
Bringing comments from @jameshadfield over from Slack for ease of change-tracking:
|
Yeah, I found the RefSeq for yellow fever virus and it's got a complete breakdown, so I can do this.
👍
I'm hearing "maybe down the road but not critical path" here, push back if that's wrong.
kk.
👍
yep, saw that error during build, thanks for highlight. |
💯 - not something for the initial build! Looking at this again today there are signs of recombination in the tree, although the literature suggest[s] that recombination between YFV strains is unlikely. The high number of homoplasies on the deep branches, and the clustering of them, sure looks consistent with recombination - e.g. 5389G,5437T,5443T,5485A,5497T. If this is more prevalent deeper in the tree it would result in less clock signal, or said another way the clock signal might still be ok for individual YF-genotypes. It'd be useful if Auspice were able to show a colouring for unique mutation counts, homoplasic counts and the ratio. I'll look into this at some point. Could even use these as branch metrics if we get around to nextstrain/auspice#1769. |
* sync `ingest/README` with `seasonal-cov` version * move from `defaults` to `config` for config files * strip fetch-from-entrez stuff from config and rules files * add `ncbi_taxon_id` to config * strip guidance comments, light reformat of Snakemake and rules files for readability * add benchmarks where missing * remove unused nextclade bits * add "clean" convenience rule
f0e18fe
to
f6795e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ingest again, works for me!
No description provided.