Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output notebook #167

Merged
merged 8 commits into from
Oct 13, 2023
Merged

Output notebook #167

merged 8 commits into from
Oct 13, 2023

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Oct 12, 2023

Close #166

I have checked, and rendered an HTML report from the R markdown produced in this way.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @pinin4fjords,

It looks like this pull-request is has been made against the nf-core/differentialabundance master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/differentialabundance dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@pinin4fjords pinin4fjords changed the base branch from master to dev October 12, 2023 12:56
@github-actions
Copy link

github-actions bot commented Oct 12, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 7332de5

+| ✅ 159 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in WorkflowDifferentialabundance.groovy: Optionally add in-text citation tools to this list.

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-12 15:11:11

@pinin4fjords pinin4fjords marked this pull request as draft October 12, 2023 13:00
@pinin4fjords pinin4fjords added this to the 1.3.0 milestone Oct 12, 2023
@pinin4fjords pinin4fjords requested a review from WackerO October 12, 2023 15:14
@pinin4fjords pinin4fjords marked this pull request as ready for review October 12, 2023 15:55
Copy link
Collaborator

@WackerO WackerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pinin4fjords
Copy link
Member Author

Thanks @WackerO !

@drpatelh - we add any revisions you'd like to this functionality in subsequent PRs.

@pinin4fjords pinin4fjords merged commit 8f78242 into dev Oct 13, 2023
14 checks passed
@pinin4fjords pinin4fjords deleted the output_notebook branch October 13, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output a parameter-resolved R Markdown document, as well as rendered HTML
2 participants