-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed genome only option not working #57
Conversation
Great, ok, lets wait for our first review, and then push it. I will test it now |
As mentioned in #53:
|
Hi @chriswyatt1, looks like meryl and merqury are working fine on the test datasets. I think this is ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That all looks good, have tested it and works as expected. Questions/Comments:
-
Will the pipeline now work with mixed inputs, e.g. some with just genomes, other with refseq IDs, etc.?
-
Maybe we should add a option on the REAMDE for this already.
Although the README does require a revamp with all the new modules/subworkflows added.
It works like this:
Yeah, I haven't look at the README. I'll check tomorrow and see what can I add. Probably a lot. |
I also added |
Fixed
--genome_only
option not working.