Update dragmap + add nf-test

[nvnieuwk]

PR checklist

Closes #XXX

• This comment contains a description of changes (with reason).
• If you've fixed a bug or added code that should be tested, add tests!
• If you've added a new tool - have you followed the module conventions in the contribution docs
• If necessary, include test data in your PR.
• Remove all TODO statements.
• Emit the versions.yml file.
• Follow the naming conventions.
• Follow the parameters requirements.
• Follow the input/output options guidelines.
• Add a resource label
• Use BioConda and BioContainers if possible to fulfil software requirements.
• Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
  • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
  • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
  • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

[maxulysse]

not 1.17?

[nvnieuwk]

It's 1.16 in the mulled container, so I'd rather keep them the same

[FriederikeHanssen]

in that case maybe update the mulled container as well? but in any case 1.3.0 has a bunch of issues to my knowledge Illumina/DRAGMAP#47

[nvnieuwk]

BioContainers/multi-package-containers#2839

[edmundmiller]

I also have the 1.3.0 bug, so I don't know if we can move forward.

Illumina/DRAGMAP@c4cb6c9

It looks like there's a 1.3.1 but they didn't tag it properly, so bioconda didn't create a release.

[edmundmiller]

It's GPL3, do we fork it? 😆 There's a lot of improvement PRs

[nvnieuwk]

Good for me :p (And I know the tests are failing, I still need to do a small fix)

[edmundmiller]

Remove the pytest-workflow tests.

Let's just merge it, I won't update it in Nascent 🙃

I forked it & and cut a 1.3.1. Might merge a few of the PRs into it, and add my fork to bioconda. Or maybe I'll get distracted and forget about it, who knows? https://github.com/Emiller88/NARFMAP/releases/tag/1.3.1

[nvnieuwk]

I'd rather wait for your updates then so we're sure it works as intended 😁

[edmundmiller]

I think that'll be a whole new module. I think this is as far as dragmap is gonna get, they never tagged the 1.3.1 release. So we might as well merge this?

[nvnieuwk]

Fair enough 🤷