-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dragmap + add nf-test #4379
Merged
Merged
Changes from 25 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
8df2221
new module picard/scatterintervalsbyns
nvnieuwk 3780c6c
update annotsv to 3.3.6
nvnieuwk 4a4979c
Merge branch 'master' into annotsv-update
nvnieuwk 5533a7e
update installannotations
nvnieuwk 0b8330f
Merge branch 'annotsv-update' of github.com:nvnieuwk/modules into ann…
nvnieuwk f772c25
Merge branch 'nf-core:master' into master
nvnieuwk d84dc41
Merge branch 'nf-core:master' into master
nvnieuwk f980e00
Merge branch 'nf-core:master' into master
nvnieuwk e82b71c
Merge branch 'nf-core:master' into master
nvnieuwk 289314b
Merge branch 'nf-core:master' into master
nvnieuwk eb7ca02
Merge branch 'nf-core:master' into master
nvnieuwk a228da4
Merge branch 'nf-core:master' into master
nvnieuwk 0ea95a6
Merge branch 'nf-core:master' into master
nvnieuwk 3c261a9
Merge branch 'nf-core:master' into master
nvnieuwk 0fb316e
Merge branch 'nf-core:master' into master
nvnieuwk 9ffac7a
Merge branch 'nf-core:master' into master
nvnieuwk d8c3233
Merge branch 'nf-core:master' into master
nvnieuwk 0623022
Merge branch 'nf-core:master' into master
nvnieuwk ecda643
Merge branch 'nf-core:master' into master
nvnieuwk 2786065
Merge branch 'nf-core:master' into master
nvnieuwk 793f1a2
Merge branch 'nf-core:master' into master
nvnieuwk a77c897
Merge branch 'nf-core:master' into master
nvnieuwk a849af6
Merge branch 'nf-core:master' into master
nvnieuwk 9cbb88a
Merge branch 'nf-core:master' into master
nvnieuwk cd8be0d
update dragmap modules + add nf-test
nvnieuwk 64b5432
fix singularity container
nvnieuwk 3757489
add human test + stubs
nvnieuwk 08fc092
fix tests
nvnieuwk da7bdaa
update mulled containers + conda env
nvnieuwk aaca843
fix tests
nvnieuwk 47b304d
Merge branch 'master' into update-dragmap
nvnieuwk 548ff0f
Merge branch 'master' into update-dragmap
nvnieuwk 290cb8d
chore: Remove pytest-workflow tests
edmundmiller a45e945
Merge branch 'master' into update-dragmap
nvnieuwk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,185 @@ | ||
nextflow_process { | ||
|
||
name "Test Process DRAGMAP_ALIGN" | ||
script "../main.nf" | ||
process "DRAGMAP_ALIGN" | ||
tag "modules" | ||
tag "modules_nfcore" | ||
tag "dragmap" | ||
tag "dragmap/align" | ||
|
||
test("sarscov2 - fastq, hashtable, false") { | ||
|
||
setup { | ||
run("DRAGMAP_HASHTABLE") { | ||
script "../../hashtable/main.nf" | ||
process { | ||
""" | ||
input[0] = [ | ||
[id:'test'], | ||
file(params.test_data['sarscov2']['genome']['genome_fasta'], checkIfExists: true) | ||
] | ||
""" | ||
} | ||
} | ||
} | ||
|
||
when { | ||
process { | ||
""" | ||
input[0] = [ | ||
[ id:'test', single_end:true ], // meta map | ||
file(params.test_data['sarscov2']['illumina']['test_1_fastq_gz'], checkIfExists: true) | ||
] | ||
input[1] = DRAGMAP_HASHTABLE.out.hashmap | ||
input[2] = false //sort | ||
""" | ||
} | ||
} | ||
|
||
then { | ||
assertAll ( | ||
{ assert process.success }, | ||
{ assert snapshot( | ||
file(process.out.bam[0][1]).name, | ||
file(process.out.log[0][1]).readLines()[2..4], | ||
file(process.out.versions[0]).name | ||
).match() } | ||
) | ||
} | ||
|
||
} | ||
|
||
test("sarscov2 - fastq, hashtable, true") { | ||
|
||
setup { | ||
run("DRAGMAP_HASHTABLE") { | ||
script "../../hashtable/main.nf" | ||
process { | ||
""" | ||
input[0] = [ | ||
[id:'test'], | ||
file(params.test_data['sarscov2']['genome']['genome_fasta'], checkIfExists: true) | ||
] | ||
""" | ||
} | ||
} | ||
} | ||
|
||
when { | ||
process { | ||
""" | ||
input[0] = [ | ||
[ id:'test', single_end:true ], // meta map | ||
file(params.test_data['sarscov2']['illumina']['test_1_fastq_gz'], checkIfExists: true) | ||
] | ||
input[1] = DRAGMAP_HASHTABLE.out.hashmap | ||
input[2] = true //sort | ||
""" | ||
} | ||
} | ||
|
||
then { | ||
assertAll ( | ||
{ assert process.success }, | ||
{ assert snapshot( | ||
file(process.out.bam[0][1]).name, | ||
file(process.out.log[0][1]).readLines()[2..4], | ||
file(process.out.versions[0]).name | ||
).match() } | ||
) | ||
} | ||
|
||
} | ||
|
||
test("sarscov2 - [fastq1, fastq2], hashtable, false") { | ||
|
||
setup { | ||
run("DRAGMAP_HASHTABLE") { | ||
script "../../hashtable/main.nf" | ||
process { | ||
""" | ||
input[0] = [ | ||
[id:'test'], | ||
file(params.test_data['sarscov2']['genome']['genome_fasta'], checkIfExists: true) | ||
] | ||
""" | ||
} | ||
} | ||
} | ||
|
||
when { | ||
process { | ||
""" | ||
input[0] = [ | ||
[ id:'test', single_end:false ], // meta map | ||
[ | ||
file(params.test_data['sarscov2']['illumina']['test_1_fastq_gz'], checkIfExists: true), | ||
file(params.test_data['sarscov2']['illumina']['test_2_fastq_gz'], checkIfExists: true) | ||
] | ||
] | ||
input[1] = DRAGMAP_HASHTABLE.out.hashmap | ||
input[2] = false //sort | ||
""" | ||
} | ||
} | ||
|
||
then { | ||
assertAll ( | ||
{ assert process.success }, | ||
{ assert snapshot( | ||
file(process.out.bam[0][1]).name, | ||
file(process.out.log[0][1]).readLines()[2..4], | ||
file(process.out.versions[0]).name | ||
).match() } | ||
) | ||
} | ||
|
||
} | ||
|
||
test("sarscov2 - [fastq1, fastq2], hashtable, true") { | ||
|
||
setup { | ||
run("DRAGMAP_HASHTABLE") { | ||
script "../../hashtable/main.nf" | ||
process { | ||
""" | ||
input[0] = [ | ||
[id:'test'], | ||
file(params.test_data['sarscov2']['genome']['genome_fasta'], checkIfExists: true) | ||
] | ||
""" | ||
} | ||
} | ||
} | ||
|
||
when { | ||
process { | ||
""" | ||
input[0] = [ | ||
[ id:'test', single_end:false ], // meta map | ||
[ | ||
file(params.test_data['sarscov2']['illumina']['test_1_fastq_gz'], checkIfExists: true), | ||
file(params.test_data['sarscov2']['illumina']['test_2_fastq_gz'], checkIfExists: true) | ||
] | ||
] | ||
input[1] = DRAGMAP_HASHTABLE.out.hashmap | ||
input[2] = true //sort | ||
""" | ||
} | ||
} | ||
|
||
then { | ||
assertAll ( | ||
{ assert process.success }, | ||
{ assert snapshot( | ||
file(process.out.bam[0][1]).name, | ||
file(process.out.log[0][1]).readLines()[2..4], | ||
file(process.out.versions[0]).name | ||
).match() } | ||
) | ||
} | ||
|
||
} | ||
|
||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
dragmap/align: | ||
- modules/nf-core/dragmap/align/** |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
nextflow_process { | ||
|
||
name "Test Process DRAGMAP_HASHTABLE" | ||
script "../main.nf" | ||
process "DRAGMAP_HASHTABLE" | ||
tag "modules" | ||
tag "modules_nfcore" | ||
tag "dragmap" | ||
tag "dragmap/hashtable" | ||
|
||
test("sarscov2 - fasta") { | ||
|
||
when { | ||
|
||
process { | ||
""" | ||
input[0] = [ | ||
[id:'test'], | ||
file(params.test_data['sarscov2']['genome']['genome_fasta'], checkIfExists: true) | ||
] | ||
""" | ||
} | ||
} | ||
|
||
then { | ||
assertAll( | ||
{ assert process.success }, | ||
{ assert snapshot( | ||
file(process.out.hashmap[0][1]).name, | ||
file(process.out.versions[0]).name | ||
).match() | ||
} | ||
) | ||
} | ||
|
||
} | ||
|
||
// TODO Add test using alt-masked bed file | ||
// https://github.com/Illumina/dragmap#build-hash-table-using-an-alt-masked-bed-file | ||
|
||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
dragmap/hashtable: | ||
- modules/nf-core/dragmap/hashtable/** |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not 1.17?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's 1.16 in the mulled container, so I'd rather keep them the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in that case maybe update the mulled container as well? but in any case 1.3.0 has a bunch of issues to my knowledge Illumina/DRAGMAP#47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BioContainers/multi-package-containers#2839
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also have the 1.3.0 bug, so I don't know if we can move forward.
Illumina/DRAGMAP@c4cb6c9
It looks like there's a 1.3.1 but they didn't tag it properly, so bioconda didn't create a release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's GPL3, do we fork it? 😆 There's a lot of improvement PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me :p (And I know the tests are failing, I still need to do a small fix)