Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix final language server errors in template #3294

Closed
ewels opened this issue Nov 22, 2024 · 2 comments · Fixed by #3296
Closed

Fix final language server errors in template #3294

ewels opened this issue Nov 22, 2024 · 2 comments · Fixed by #3296
Labels
template nf-core pipeline/component template
Milestone

Comments

@ewels
Copy link
Member

ewels commented Nov 22, 2024

There are still one or two errors in newly generated pipelines from nf-core pipelines create that get flagged by the new Nextflow language server / VS Code extension. For example, there's a def in the nextflow.config.

We should clean these up and ensure that new pipelines / synced pipelines have no errors.

Once we have a Nextflow CLI tool for checking errors we can automate this test - but for now we can do it manually.

@ewels ewels added the template nf-core pipeline/component template label Nov 22, 2024
@ewels ewels added this to the 3.1 milestone Nov 22, 2024
@ewels
Copy link
Member Author

ewels commented Nov 23, 2024

From @bentsherman:

You could do something like this:

params.trace_timestamp = new java.util.Date().format( 'yyyy-MM-dd_HH-mm-ss')
timeline {
    enabled = true
    file    = "${params.outdir}/pipeline_info/execution_timeline_${params.trace_timestamp}.html"
}

Maybe we call it "report suffix" or something more generic. Then set it to hidden in the JSON schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template nf-core pipeline/component template
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants