Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow main as default channel #3142

Merged
merged 23 commits into from
Dec 5, 2024
Merged

Allow main as default channel #3142

merged 23 commits into from
Dec 5, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Aug 27, 2024 •
edited
Loading

Closes #1931

@mashehu mashehu changed the base branch from master to dev August 27, 2024 05:34
@nf-core nf-core deleted a comment from github-actions bot Aug 27, 2024
@ewels
Copy link
Member

ewels commented Oct 10, 2024

Configs: Can rename to main but then create a master branch that has just the nfcore_custom.config file there which then in turn redirects to the correct file on main.

Also need the pipeline includes.

@ewels ewels added this to the 3.1 milestone Nov 21, 2024
mashehu
mashehu commented Dec 3, 2024
View reviewed changes
nf_core/components/create.py Outdated Show resolved Hide resolved
mashehu and others added 5 commits December 3, 2024 13:38
@mashehu
Update nf_core/components/create.py
bd9608d
@mashehu
Merge branch 'main' of github.com:nf-core/tools into master-to-main
73957fd 
# Conflicts:
#	.github/RELEASE_CHECKLIST.md
#	.github/workflows/branch.yml
#	.github/workflows/pytest.yml
#	nf_core/pipeline-template/README.md
#	nf_core/pipeline-template/assets/schema_input.json
#	nf_core/pipeline-template/nextflow_schema.json
@mashehu
Merge branch 'dev' into master-to-main
831548e
@mashehu
set defaultBranch in nextflow config to allow main
e9ed94e
@mashehu
pin java version 21 in CI
00b8ae0
@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.88%. Comparing base (eed0598) to head (ce866c6).
Report is 55 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/pipelines/schema.py 66.66% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mirpedrol
mirpedrol approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions to remove setup-java as it's not needed any more :)

.github/actions/create-lint-wf/action.yml Outdated Show resolved Hide resolved
.github/workflows/create-test-lint-wf-template.yml Outdated Show resolved Hide resolved
.github/workflows/create-test-wf.yml Outdated Show resolved Hide resolved
.github/workflows/pytest.yml Outdated Show resolved Hide resolved
nf_core/pipeline-template/.github/workflows/ci.yml Outdated Show resolved Hide resolved
nf_core/pipeline-template/.github/workflows/download_pipeline.yml Outdated Show resolved Hide resolved
nf_core/pipeline-template/.github/workflows/linting.yml Outdated Show resolved Hide resolved
@mirpedrol mirpedrol merged commit e8510cc into nf-core:dev Dec 5, 2024
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

Main instead of master for branch name when generating a new pipeline?
3 participants
@mashehu @ewels @mirpedrol