Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve subworkflow nf-test migration warning #3298

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Improve subworkflow nf-test migration warning #3298

wants to merge 1 commit into from

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Nov 25, 2024 •
edited
Loading

Closes #3297

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@edmundmiller edmundmiller self-assigned this Nov 25, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.62%. Comparing base (4e4bbaa) to head (805620b).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

mirpedrol
mirpedrol approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
remember to update the changelog 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

@mashehu mashehu mashehu approved these changes

Assignees

@edmundmiller edmundmiller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edmundmiller @mashehu @mirpedrol