Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added identifieres for Person and ScholarlyArticle #19

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Added identifieres for Person and ScholarlyArticle #19

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfde1ee
Added identifieres for Person and ScholarlyArticle
floWetzels May 22, 2024
4a3b3ba
Updated person name properties
floWetzels May 22, 2024
6f9cf66
Update isa_ro_crate.md
floWetzels Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions profile/isa_ro_crate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,9 @@ It is based on [schema.org/Person](https://schema.org/Person), and maps to the [
|----------|----------|---------------|-------------|
|@type |MUST|Text|must be '[schema.org/Person](https://schema.org/Person)'|
|@id|MUST|Text or URL||
|givenName|MUST|Text||
|familyName|MUST|Text||
|name|MUST|Text||
|email|SHOULD|Text||
|identifier|SHOULD|Text or URL or [schema.org/PropertyValue](https://schema.org/PropertyValue)|One or many identifiers for this person, e.g. an ORCID. Can be of type PropertyValue to indicate the kind of reference.|
|affiliation|SHOULD|[schema.org/Organization](https://schema.org/Organization)||
|jobTitle|SHOULD|[schema.org/DefinedTerm](https://schema.org/DefinedTerm)||
|additionalName|COULD|Text||
Expand All @@ -248,9 +248,10 @@ It is based on [schema.org/ScholarlyArticle](https://schema.org/ScholarlyArticle
|headline|MUST|Text||
|author|SHOULD|[schema.org/Person](https://schema.org/Person)||
|url|SHOULD|URL||
|identifier|SHOULD|Text or URL or [schema.org/PropertyValue](https://schema.org/PropertyValue)|One or many identifiers for this article like a DOI or PubMedID. Can be of type PropertyValue to indicate the kind of reference.|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't sameAs be thrown out in favor of identifier?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be that you're mixing up Issues/PRs here? I can't follow you.

|creativeWorkStatus|COULD|[schema.org/DefinedTerm](https://schema.org/DefinedTerm)|The status of the publication in terms of its stage in a lifecycle.|
|disambiguatingDescription|COULD|Text|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is disambiguatingDescription referring to in this context?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember exactly, but my guess would be the comments from ISA.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you even mentioned it in Issue #3


## Example ro-crate-metadata.json

_TODO: simple example and a link to a more complete example_
_TODO: simple example and a link to a more complete example_