Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Redesign #72

Open
4 tasks
figsoda opened this issue Mar 16, 2023 · 4 comments
Open
4 tasks

UI Redesign #72

figsoda opened this issue Mar 16, 2023 · 4 comments
Labels

Comments

@figsoda
Copy link
Member

figsoda commented Mar 16, 2023

The current tui is far from perfect, file path completions have some unconventional behavior, and we are simulating selection with completions

@figsoda figsoda added the ui/ux label Mar 16, 2023
@RaitoBezarius
Copy link
Member

I don't know if should go here, but sourceRoot support would be awesome.

@Kranzes
Copy link
Member

Kranzes commented May 5, 2023

The order of the interactive questions isn't very intuitive in my opinion. Right now the output path is asked first then URL and so on. For me at least, it makes much more sense to have URL as the first question then the other packaging related ones and finally the output path. I think in many interactive tools for generating some spec the output path is the last thing being asked.

Almost all the times I use nix-init I accidentally put the URL as the first answer automatically and since the file creating isn't truly atomic (gets created even if nix-init doesn't exit with code 0) I end up with a directory like this:

Enter output path (defaults to current directory)
❯ https://github.com/nix-community/nix-init
Enter url
❯

Error: Interrupted
[kranzes@pongo ~/test]$ ls
https:
[kranzes@pongo ~/test]$ tree
.
└── https:
    └── github.com
        └── nix-community
            └── nix-init

3 directories, 1 file

@Kranzes
Copy link
Member

Kranzes commented May 5, 2023

nix-template supports writing the output file automatically to a directory in a nixpkgs checkout. I think we could add an option to do the same in nix-init, this should be pretty for python packages as their location in nixpkgs isn't category based but rather pname based, in addition, it could also add it to to pkgs/top-level/python-packages.nix.

@figsoda
Copy link
Member Author

figsoda commented May 5, 2023

writing the output file automatically to a directory in a nixpkgs checkout

This sounds useful for buildPythonPackage, though I'm not sure about other types of packages. I am mostly waiting for NixOS/rfcs#140

This would also be a good argument for prompting for URL (and probably pname) before the output path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants