-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace eval_global_as_array_length
with type/interpreter evaluation
#6469
Draft
michaeljklein
wants to merge
13
commits into
master
Choose a base branch
from
michaeljklein/global-as-type
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… name to Rc<String>
…rger than u32::MAX' tests, removed unused EvaluatedGlobalIsntU32 check and type, move (global -> type) one-step conversion to node interner for now, implement global types in the monomorphizer and printer
…andling for Value -> Type::Constant, wip cleanup
…es with Kind::Numeric
Discussed in 1:1 that we're going to require globals to have their type declared explicitly which also fixes the issues in this PR. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #6238
Summary*
Current plan:
Type::InfixExpr
/Type::Constant
if possibleType::Global(GlobalId)
comptime
globals otherwise (to allow using the existing interpreter)comptime
eval_global_as_array_length
Additional Context
numeric_generic_field_larger_than_u32
: Using largeField
's in numeric generics fails with "array length too large" #6125numeric_generic_field_arithmetic_larger_than_u32
:Field
computed to be larger thanu32::MAX
with arithmetic generics panics #6126Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.