Update Fireblocks Signer #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Fireblocks Signer
🚨 Vulnerabilities Summary
For more details view the full report in OpenZeppelin Code |
|
✅ Linked to Task NO-3258 · Update Fireblocks signer in contracts repo |
Codecov Report
@@ Coverage Diff @@
## master #706 +/- ##
======================================
Coverage 54.7% 54.7%
======================================
Files 14 14
Lines 979 979
Branches 152 152
======================================
Hits 536 536
Misses 386 386
Partials 57 57 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jaycenhorton
previously approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NO-3258
Updates the contracts repo hardhat infrastructure away from our old custom Fireblocks signer to instead use the recommended hardhat integration (which didn't exist when we were initially building this so Scott put together something custom). We also extend the base implementation of the fireblocks-hardhat integration to implement complete ethers Signer functionality. The custom integration was no longer working when we revisited it this month to perform some script-based listing and while it's not clear whether it's deprecated beyond salvation (for example, if the Fireblocks rest API is no longer live, then it is) we figure the easier and likely inevitable fix is to migrate to this finally mature third-party library created by Fireblocks, especially given the complexity of the custom implementation.