Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fireblocks Signer #706

Merged
merged 8 commits into from
Oct 4, 2023
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions config/fireblocks.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import type { HardhatUserConfig } from 'hardhat/types';
import type { HardhatUserConfig } from 'hardhat/types/config';

const { FIREBLOCKS_API_KEY, FIREBLOCKS_SECRET_KEY_PATH, FIREBLOCKS_VAULT_ID } =
process.env;

export const fireblocks: HardhatUserConfig['fireblocks'] =
FIREBLOCKS_API_KEY && FIREBLOCKS_SECRET_KEY_PATH

Check warning on line 7 in config/fireblocks.ts

View workflow job for this annotation

GitHub Actions / lint

Unexpected nullable string value in conditional. Please handle the nullish/empty cases explicitly

Check warning on line 7 in config/fireblocks.ts

View workflow job for this annotation

GitHub Actions / lint

Unexpected nullable string value in conditional. Please handle the nullish/empty cases explicitly
? {
apiKey: FIREBLOCKS_API_KEY,
apiSecret: FIREBLOCKS_SECRET_KEY_PATH,
vaultId: FIREBLOCKS_VAULT_ID,
privateKey: FIREBLOCKS_SECRET_KEY_PATH,
vaultAccountIds: FIREBLOCKS_VAULT_ID,
}
: undefined;
5 changes: 5 additions & 0 deletions config/networks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import type * as contractsConfig from '../contracts.json';

import { accounts } from './accounts';
import { fireblocks } from './fireblocks';

export type ContractsInNetwork<
T extends SupportedNetworks = SupportedNetworks
Expand Down Expand Up @@ -56,6 +57,7 @@
...(typeof MNEMONIC === 'string' && {
accounts: { mnemonic: MNEMONIC },
}),
fireblocks,
};

const mumbai: NetworkUserConfig = {
Expand All @@ -67,6 +69,7 @@
...(typeof MNEMONIC === 'string' && {
accounts: { mnemonic: MNEMONIC },
}),
fireblocks,
};

const polygon: NetworkUserConfig = {
Expand All @@ -75,6 +78,7 @@
gasPrice: 50_000_000_000,
live: true,
tags: ['polygon', 'prod'],
fireblocks,
};

const mainnet: NetworkUserConfig = {
Expand All @@ -83,6 +87,7 @@
gasPrice: 50_000_000_000,
live: true,
tags: ['mainnet', 'prod'],
fireblocks

Check warning on line 90 in config/networks.ts

View workflow job for this annotation

GitHub Actions / lint

Insert `,`
};

export const networks = {
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
"@ethersproject/abstract-signer": "5.7.0",
"@ethersproject/properties": "5.7.0",
"@ethersproject/providers": "5.7.2",
"@fireblocks/fireblocks-web3-provider": "^1.2.4",
"@fireblocks/hardhat-fireblocks": "^1.2.2",
"@nomiclabs/hardhat-ethers": "^2.2.3",
"@nomiclabs/hardhat-etherscan": "^3.1.7",
"@nomiclabs/hardhat-waffle": "^2.0.3",
Expand Down Expand Up @@ -62,8 +64,6 @@
"ethereum-waffle": "^3.4.4",
"ethernal": "^2.0.2",
"ethers": "^5.7.2",
"fireblocks-defi-sdk": "1.2.15",
"fireblocks-sdk": "^4.0.0",
"fs-extra": "^10.1.0",
"google-artifactregistry-auth": "^3.1.0",
"handlebars": "^4.7.7",
Expand Down
32 changes: 0 additions & 32 deletions plugins/fireblocks/README.md

This file was deleted.

Loading
Loading