-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Drop support for yaml-cpp old API #450
refactor: Drop support for yaml-cpp old API #450
Conversation
Breaking changes: - Use the new yaml-cpp API, i.e. version 0.5+. - No longer provide sources in the contrib directory.
Can one of the admins verify this patch? |
add to white list |
ok to test |
Tests are failing on OSX
|
I have built it on jetson nano with yaml-cpp 0.5, but failure with some tests. [ RUN ] Transformation.ComputeRigidTransformDataPoints3D /mnt/c/nano/git/libpointmatcher/utest/ui/Transformations.cpp:39: Failure Value of: transformedFeature.isApprox(transformedCloud.features.col(i), kEpsilonNumericalError) Actual: false Expected: true [ FAILED ] Transformation.ComputeRigidTransformDataPoints3D (17 ms) [ RUN ] Transformation.ComputeSimilarityTransformDataPoints2D [ OK ] Transformation.ComputeSimilarityTransformDataPoints2D (40 ms) [ RUN ] Transformation.ComputeSimilarityTransformDataPoints3D /mnt/c/nano/git/libpointmatcher/utest/ui/Transformations.cpp:39: Failure Value of: transformedFeature.isApprox(transformedCloud.features.col(i), kEpsilonNumericalError) Actual: false Expected: true [ FAILED ] Transformation.ComputeSimilarityTransformDataPoints3D (27 ms) [----------] 7 tests from Transformation (135 ms total) [----------] Global test environment tear-down [==========] 80 tests from 13 test cases ran. (87892 ms total) [ PASSED ] 78 tests. [ FAILED ] 2 tests, listed below: [ FAILED ] Transformation.ComputeRigidTransformDataPoints3D [ FAILED ] Transformation.ComputeSimilarityTransformDataPoints3D |
Hi @xlla! On Ubuntu 18.04, all the tests pass. So, I'm not sure that the problem comes from the refactor of the yaml-cpp API. Have you tried to run the tests on the master branch (i.e. using the old yaml-cpp API)? If not, can you please try it and tell me if you get the same tests failure? It's just to be sure that it's not related with the changed from this branch. Thanks! |
fix #42
So, here's my attempt to upgrade libpointmatcher's
yaml-cpp
dependency to its new API.As discuss in #42,
libpointmatcher
will no longer providesyaml-cpp
sources in the contrib directory, which mean that Windows users will have to build and installyaml-cpp
from sources.I've followed this tutorial to upgrade the API.
Changes:
Tested on:
However, these changes need to be tested on Windows, so if a Windows user feels generous and is willing to test them, it would be greatly appreciated. 😄
Any suggestions are welcomed. Thanks!