Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link OpenMP with modern CMake #548

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Link OpenMP with modern CMake #548

merged 6 commits into from
Dec 16, 2024

Conversation

boxanm
Copy link
Collaborator

@boxanm boxanm commented Dec 29, 2023

Simplifies OpenMP import in CMakeLists.txt.
From https://cliutils.gitlab.io/modern-cmake/chapters/packages/OpenMP.html:

OpenMP support was drastically improved in CMake 3.9+. The Modern(TM) way to add OpenMP to a target is:

Checklist:

Code related

  • I have made corresponding changes to the documentation
    (i.e.: function, class, script header, README.md)
  • I have commented hard-to-understand code
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
    (Check README.md #Contributing
    for local testing procedure using libpointmatcher-build-system)

PR creation related

  • My pull request base ref branch is set to the develop branch
    (the build-system won't be triggered otherwise)
  • My pull request branch is up-to-date with the develop branch
    (the build-system will reject it otherwise)

PR description related

  • I have included a quick summary of the changes
  • I have indicated the related issue's id with # <issue-id> if changes are of type fix
  • I have included a high-level list of changes and their corresponding type
    • Types: feat fix docs style refactor perf test build ci chore revert
    • Breaking changes: <type>!
    • Reference:
      see commit_msg_reference.md
      in the repository root for details

Note for repository admins

Release PR related

  • Only repository admins have the privilege to push/merge on the default branch (ie: master)
    and the release branch.
  • Keep PR in draft mode until all the release reviewers are ready to push the release.
  • Once a PR from release -> master branch is created (not in draft mode),
    • it triggers the build-system test
    • (in-progress) and it triggers the semantic release automation

@boxanm boxanm changed the title Modern open mp Link OpenMP with modern CMake Dec 29, 2023
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@boxanm boxanm marked this pull request as ready for review December 16, 2024 18:13
@boxanm boxanm merged commit 970f8f2 into develop Dec 16, 2024
8 checks passed
@boxanm boxanm deleted the modern_OpenMP branch December 16, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant