-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angle limit filter #591
Merged
Merged
Angle limit filter #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change minimal CMake version to 3.15, add MacOS-specific files to .gitignore
- Support newer Pybind11 versions - Support pybind installed with pip
boxanm
requested review from
RedLeader962,
simonpierredeschenes,
aguenette and
pomerlef
as code owners
December 9, 2024 17:31
# Conflicts: # .github/workflows/build-python.yaml # pointmatcher/IO.cpp
The code looks fine, except for the angle_min and angle_max variables which are not necessary. I also think that unit tests should be added. |
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary:
Add a new DataPointsFilter that filters points based on if they lie inside / outside of a given spherical wedge.
The spherical wedge is defined by the lower and upper bounds of two angles in spherical coordinates.
The angles follow the spherical physics convention, as described on Wikipedia https://en.wikipedia.org/wiki/Spherical_coordinate_system
Changes and type of changes (quick overview):
Checklist:
Code related
(i.e.: function, class, script header, README.md)
(Check contributing_instructions.md for local testing procedure using libpointmatcher-build-system)
PR creation related
base ref
branch is set to thedevelop
branch(the build-system won't be triggered otherwise)
develop
branch(the build-system will reject it otherwise)
PR description related
# <issue-id>
if changes are of typefix
(See commit_msg_reference.md for details)