top-level refactor #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimbatm
force-pushed
the
refactor
branch
2 times, most recently
from
5b3c717 to
31ea1a4
Compare
zimbatm
force-pushed
the
refactor
branch
3 times, most recently
from
b4d4736 to
fdc4ac6
Compare
brianmcgee
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
I like this refactor. I especially like the top-level devshell.nix and formatter.nix.
It would be nice to have a simple way of pointing the default package at one of the other packages. Currently, the only way I can think of doing that would be something like this in package.nix:
{ pkgs, flake, ...}: flake.packages.${pkgs.system}.fooFor very simple flakes, it doesn't make sense to create a whole folder
structure.
ADDITIONS:
* Add a top-level package.nix that maps to `packages.<system>.default`
* Add a top-level formatter.nix that maps to `formatter.<system>` and `packages.<system>.formatter`.
* Load devshells from the devshells/ folder.
CHANGES:
* perSystem values now merge legacyPackages and packages in that order.
* packages are loaded with `callPackage`.
BREAKING:
* Remove `packages/<pname>/package.nix` as it makes the interface too
complicated.
* lib/default.nix: take `{ flake, inputs }:` instead of `inputs`.
This is now covered in the main docs
I added #18 to keep track of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For very simple flakes, it doesn't make sense to create a whole folder
structure.
ADDITIONS:
packages.<system>.defaultformatter.<system>andpackages.<system>.formatter.CHANGES:
callPackage.BREAKING:
packages/<pname>/package.nixas it makes the interface toocomplicated.
{ flake, inputs }:instead ofinputs.