Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new 'response to chemical' term for GWAS #275

Merged
merged 6 commits into from
Aug 3, 2023
Merged

Conversation

ar-ibrahim
Copy link
Collaborator

@ar-ibrahim ar-ibrahim requested a review from rays22 August 1, 2023 09:37
@ar-ibrahim
Copy link
Collaborator Author

@rays22 After updating the chebi slim and importing the chebi term for the new term request, there's a new QC error unrelated to my issue:

ERROR	misused_obsolete_label	OBA:0006023	rdfs:label	obsolete proline oxidase activity rate
ERROR	misused_obsolete_label	OBA:1000857	rdfs:label	obsolete proline oxidase activity quality

What are your thoughts on this?

@rays22
Copy link
Contributor

rays22 commented Aug 1, 2023

ERROR	misused_obsolete_label	OBA:0006023	rdfs:label	obsolete proline oxidase activity rate
ERROR	misused_obsolete_label	OBA:1000857	rdfs:label	obsolete proline oxidase activity quality

@ar-ibrahim ,
In cases like this, when the GO term component becomes obsolete, you need to find an appropriate replacement, or do a manual term edit in Protege.
In the present case, there is a replacement suggested by GO for GO:0051699: GO:0004657 proline dehydrogenase activity. Replace the occurrences of GO:0051699 with GO:0004657 in entity_attribute.tsv.

@rays22
Copy link
Contributor

rays22 commented Aug 1, 2023

  • does the orcid ID represent the creators of the pattern or the term?

It is the ORCID of the contributor of the term.

Copy link
Contributor

@rays22 rays22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the obsolete GO component term in entity_attribute_part_of.tsv and entity_attribute.tsv and it will be fine.

@ar-ibrahim ar-ibrahim marked this pull request as ready for review August 3, 2023 10:20
@ar-ibrahim ar-ibrahim merged commit f501dfb into master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants