Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove deprecated dev templates #164

Merged
merged 3 commits into from
Sep 19, 2024
Merged

chore: Remove deprecated dev templates #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b849a43
remove deprecated dev Prometheus template
jsirianni Sep 19, 2024
402e2b7
remove dev.prometheus condition
jsirianni Sep 19, 2024
29bc06a
Regen docs
jsirianni Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/bindplane/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: bindplane
description: BindPlane OP is an observability pipeline.
type: application
# The chart's version
version: 1.17.1
version: 1.17.2
# The BindPlane OP tagged release. If the user does not
# set the `image.tag` values option, this version is used.
appVersion: 1.73.0
Expand Down
5 changes: 1 addition & 4 deletions charts/bindplane/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# bindplane

![Version: 1.17.1](https://img.shields.io/badge/Version-1.17.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.73.0](https://img.shields.io/badge/AppVersion-1.73.0-informational?style=flat-square)
![Version: 1.17.2](https://img.shields.io/badge/Version-1.17.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.73.0](https://img.shields.io/badge/AppVersion-1.73.0-informational?style=flat-square)

BindPlane OP is an observability pipeline.

Expand Down Expand Up @@ -80,9 +80,6 @@ BindPlane OP is an observability pipeline.
| dev.bindplane.auth.auth0.domain | string | `""` | |
| dev.namespace.create | bool | `false` | |
| dev.namespace.name | string | `""` | |
| dev.prometheus.create | bool | `false` | |
| dev.prometheus.image.name | string | `"prom/prometheus"` | |
| dev.prometheus.image.tag | string | `"v2.47.2"` | |
| email.sendgrid.token | string | `""` | The sendgrid API token to use when authenticating to Sendgrid. |
| email.type | string | `""` | The optional email backend type to use. Valid options include `sendgrid`. Requires an auth type other than `system`. |
| eventbus.pubsub.credentials.secret | string | `""` | Optional Kubernetes secret which contains Google Cloud JSON service account credentials. Not required when running within Google Cloud with the Pub/Sub scope enabled. |
Expand Down
129 changes: 0 additions & 129 deletions charts/bindplane/templates/prometheus.deprecated.yaml
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions charts/bindplane/templates/prometheus.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{{- if not .Values.prometheus.remote }}
{{- if not .Values.prometheus.enableSideCar }}
{{- if not .Values.dev.prometheus.create }}
apiVersion: apps/v1
kind: StatefulSet
metadata:
Expand Down Expand Up @@ -118,4 +117,3 @@ spec:
type: ClusterIP
{{- end }}
{{- end }}
{{- end }}
12 changes: 0 additions & 12 deletions charts/bindplane/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,18 +521,6 @@ dev:
# to use this namespace.
name: ""

# DEPRECATED: Use the `prometheus` top level section instead.
# Manages a prometheus deployment for development purposes. Production
# deployments should use a proper prometheus backend deployed outside
# of this chart.
prometheus:
# Whether or not prometheus should be deployed.
create: false
image:
name: prom/prometheus
# Generally this should match the version found
# here https://github.com/observIQ/bindplane-op-enterprise/blob/release/v1.38.0/PROMETHEUS_VERSION
tag: v2.47.2
bindplane:
auth:
auth0:
Expand Down
Loading