Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nats): Set K8s namespace, pod, and container name environment variables #172

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Oct 3, 2024

Description of Changes

Adds missing env variables

  • KUBERNETES_NAMESPACE_NAME
  • KUBERNETES_POD_NAME
  • KUBERNETES_CONTAINER_NAME

These are already set in the other deployments. We need these because BindPlane's internal metrics system looks them up to determine if it is running with Kubernetes or not.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes
  • Changes to ports, services, or other networking have been tested with istio

@jsirianni jsirianni marked this pull request as ready for review October 3, 2024 21:11
@jsirianni jsirianni merged commit 3b86617 into main Oct 3, 2024
19 checks passed
@jsirianni jsirianni deleted the fix/nats-k8s-env-variables branch October 3, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants