Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support pod priorityClassName #181

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Nov 20, 2024

Description of Changes

  • Added priorityClassName for all all deployments
  • Updated some docs for unrelated parameters

You can do this in your values file:

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes
  • Changes to ports, services, or other networking have been tested with istio

I deployed BindPlane HA w/ NATs.

I created a priority class:

apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
  name: high-priority
value: 1000000
globalDefault: false

And then I updated my values to include this:

priorityClassName:
  bindplane: "high-priority"
  nats: "high-priority"
  jobs: "high-priority"
  prometheus: "high-priority"
  transform_agent: "high-priority"

When I get pod -o yaml, I see:

    priorityClassName: high-priority
    priorityClassName: high-priority
    priorityClassName: high-priority
    priorityClassName: high-priority
    priorityClassName: high-priority
    priorityClassName: high-priority
    priorityClassName: high-priority

@jsirianni jsirianni marked this pull request as ready for review November 20, 2024 19:27
@jsirianni jsirianni requested a review from tbm48813 as a code owner November 20, 2024 19:27
@jsirianni jsirianni merged commit 3328b35 into main Nov 20, 2024
19 checks passed
@jsirianni jsirianni deleted the joesirianni/bpop-1277-helm-allow-setting-priorityclassname-for-all-deployments branch November 20, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants