Compatibility with odoc.2.4.1 #128
Conversation
|
@sabine odoc.2.3.0 has now been released on opam. I cannot restart the CI but everything works locally with the new release. |
|
CI restarted. There needs to be a corresponding PR on ocaml-docs-ci to pin odoc indeed. Ideally referencing back to this one, for clarity. |
|
I opened a PR on ocaml-docs-ci: ocurrent/ocaml-docs-ci#154 |
|
What co-ordination is required for the deployment of this change with docs-ci and ocaml.org? |
|
@gpetiot Could you update both PRs to use 2.3.1 that includes some bug fixes? |
|
I updated this PR and ocurrent/ocaml-docs-ci#163 to use odoc.2.3.1 |
|
@sabine @EmileTrotignon I updated the PR for odoc.2.4.0 (the only change is the integration of ocaml/odoc#949) |
| | `SourceLocationInternal (parent, name) -> | ||
| LocalName.to_string name :: full_name_aux (parent :> Identifier.t) | ||
| | `SourcePage (parent, name) -> | ||
| name :: full_name_aux (parent :> Identifier.t) |
There was a problem hiding this comment.
This is fine, although a fullname function is now shipped by odoc, so it could be deleted.
|
Let's wait for |
|
@sabine the CI is passing (except the experimental ones) on this PR, can we push it to the staging branch? |
|
It's now on staging and will be picked up by staging.docs.ci.ocamllabs.io! |
|
Seems to be okay on staging.docs.ci.ocamllabs.io, so merging this. It will take a few days for docs.ci.ocaml.org to build a sufficient number of packages, so that we can be sure the deployment worked. |
|
Did this accidentally change some urls? It looks like documentation is generated on the server as usual, but I get a 404 on every package doc on ocaml.org :( (... edit: to clarify, I have no idea if this PR is related or if something else happened!) |
|
This seems related but unintended because the documentation pipeline should be building docs in a new, non-live epoch. I passed this on to Mark. |
odoc.2.3.0 should have been released already, should be there soon.
@sabine can this be moved to the staging branch once odoc.2.3.0 is released? (the CI pipeline needs to pin this version)