Remove unconditional eprintfs and fix a broken reference #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julow
approved these changes
Sep 28, 2023
|
Wouldn't it be better to keep the warning but use the "warning framework" to control it via CLI? (If it complicates the too much and is not worth it, I'm OK with merging the changes after reformatting!) |
Closed
|
It's slightly complicated - we don't have a warnings framework for the renderers bit. We do for the compile phase, but it just didn't seem worth it right now. It made it very noisy when building docs for external dependencies in dune! |
Always forget the formatting... :-/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.