Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unconditional eprintfs and fix a broken reference #1010

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Remove unconditional eprintfs and fix a broken reference #1010

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1371f2
Remove unconditional eprintfs and fix a broken reference
jonludlam Sep 27, 2023
a6ac4cb
Formatting
jonludlam Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/document/generator.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ module Make (Syntax : SYNTAX) = struct
link1 ++ O.txt "(" ++ link2 ++ O.txt ")"
| `Resolved _ when Paths.Path.is_hidden path ->
let txt = Url.render_path path in
Format.eprintf "Warning, resolved hidden path: %s\n%!" txt;
unresolved [ inline @@ Text txt ]
| `Resolved rp -> (
(* If the path is pointing to an opaque module or module type
Expand Down
2 changes: 1 addition & 1 deletion src/odoc/fs.mli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ module Directory : sig
val append : t -> t -> t

val reach_from : dir:t -> string -> t
(** @raises Invalid_arg if [parent/name] exists but is not a directory. *)
(** @raises Invalid_argument if [parent/name] exists but is not a directory. *)

val mkdir_p : t -> unit

Expand Down
2 changes: 0 additions & 2 deletions src/xref2/tools.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1900,8 +1900,6 @@ and fragmap :
with
| Ok (p, _) -> Ok (Right p)
| Error e ->
Format.fprintf Format.err_formatter
"failed to resolve path: %a\n%!" Component.Fmt.module_path p;
Error (`UnresolvedPath (`Module (p, e)))
in
map_signature { id_map with module_ = Some (name, mapfn) } sg.items)
Expand Down
Loading