Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prevent redirection issue when clicking text or icon within button #6

Closed
wants to merge 5 commits into from
Closed

Fix prevent redirection issue when clicking text or icon within button #6

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ca9819
fix: redirect user to the intented page
rsdeus Oct 15, 2024
a6ae46c
fix prevent redirection issue when clicking text or icon within button
rsdeus Oct 16, 2024
2517005
fix: removing duplicate lines in the code
rsdeus Oct 16, 2024
7b63165
fix: npm lint errors
rsdeus Oct 16, 2024
bab5ee3
fix: minor code improvements for clarity
rsdeus Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions decidim-core/app/packs/src/decidim/append_redirect_url_to_modals.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,21 +53,30 @@ $(() => {
}

$(document).on("click.zf.trigger", (event) => {
const target = `#${$(event.target).data("dialogOpen")}`;
const redirectUrl = $(event.target).data("redirectUrl");
// Try to get the <a> directly or find the closest parent <a>
const $target = $(event.target).closest("a");

if (!target || !redirectUrl) {
return;
// Check if an <a> was found
if (!$target) {
return;
}


const dialogTarget = `#${$target.data("dialog-open")}`;
const redirectUrl = $target.data("redirectUrl");

if (!dialogTarget || !redirectUrl) {
return;
}

$("<input type='hidden' />").
attr("id", "redirect_url").
attr("name", "redirect_url").
attr("value", redirectUrl).
appendTo(`${target} form`);
appendTo(`${dialogTarget} form`);

$(`${target} a`).attr("href", (index, href) => {
const querystring = jQuery.param({ "redirect_url": redirectUrl });
$(`${dialogTarget} a`).attr("href", (index, href) => {
const querystring = jQuery.param({"redirect_url": redirectUrl});
return href + (href.match(/\?/) ? "&" : "?") + querystring;
});
});
Expand Down
Loading