-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zarr v3 #404
Open
will-moore
wants to merge
25
commits into
ome:master
Choose a base branch
from
will-moore:zarr_v3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Zarr v3 #404
+128
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes TypeError: Unsupported type for store_like: 'LocalPath'
for more information, see https://pre-commit.ci
Zarr v3 is not supported on python 3.9 or 3.10. I'll remove them from the build... Build on python 3.12 is failing tests with:
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/ome-zarr-py-development-status/104671/4 |
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress to update to Zarr v3.
This is currently focussed on getting existing Zarr v2 tests to pass...
Most of the tests are now passing using a recent commit on
main
branch of zarr-python.4 failing tests are:
These tests were passing before
* 109f71f6 (HEAD) Refactors v2 codec handling (#2425)
(zarr-developers/zarr-python#2425)This PR is just reading & writing zarr v2 data.
In several places I've hard-coded
zarr_version=2
. This works because you can dozarr.open_group(store=self.__store, path="/", zarr_version=2)
inparse_url()
to create a group to write into, or find a group to read from without specifying whether you expect the group to already exist.Without the
zarr_version=2
, zarr will createzarr.json
if the mode of the store isw
.