Add generic device; Initial support in portBLAS #552
Conversation
* oneMKL Interfaces currently only supports known targets: Intel CPU/GPU, AMD GPU, Nvidia GPU * This PR: * Enables a new generic target * Enables the generic target to use the portBLAS backend * Adds documentation
|
Hi, I have tried this (thank you) but it now fails with this error:
oneMKL (debug build) was built with the following command line: cmake .. -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang -DENABLE_MKLGPU_BACKEND=False -DENABLE_MKLGPU_BACKEND=False -DENABLE_PORTBLAS_BACKEND=True -DENABLE_CUBLAS_BACKEND=False -DENABLE_ROCBLAS_BACKEND=False -DENABLE_NETLIB_BACKEND=False -DBUILD_FUNCTIONAL_TESTS=False -DBUILD_EXAMPLES=True -DENABLE_MKLCPU_BACKEND=False -DENABLE_GENERIC_DEVICE=True |
|
|
|
Hi @al3x-jp . Did you manage to investigate your problem any further? |
| @@ -60,6 +60,9 @@ option(ENABLE_CUFFT_BACKEND "Enable the cuFFT backend for the DFT interface" OFF | |||
| option(ENABLE_ROCFFT_BACKEND "Enable the rocFFT backend for the DFT interface" OFF) | |||
| option(ENABLE_PORTFFT_BACKEND "Enable the portFFT DFT backend for the DFT interface. Cannot be used with other DFT backends." OFF) | |||
|
|
|||
| # Generic devices | |||
| option(ENABLE_GENERIC_DEVICE "Enable generic devices. Requires the portBLAS backend." OFF) | |||
There was a problem hiding this comment.
I'm not keen on adding yet another user option. Could this be automatically enabled whenever portBLAS is enabled and the default tuning target is used?
There was a problem hiding this comment.
We could.
Generic device really means an unsupported device. That means:
- It may not be tested, so there is a change of getting the wrong result.
- Errors are likely to come from somewhere other than oneMKL Interfaces.
Consequently, I think any of this functionality should explicitly be opt-in. Additionally, we currently attempt to auto-detect a tuning target if it isn't set. This behavour is probably useful, although admittedtly portBLAS is even more useful for targets that don't have a vendor library already part of oneMKL Interfaces.
There was a problem hiding this comment.
admittedtly portBLAS is even more useful for targets that don't have a vendor library already part of oneMKL Interfaces.
Yes that was my main reason to avoid having this option.
Thinking some more about it, if portBLAS always uses the "generic device" even for supported devices then it wouldn't conflict with the other backends anymore. It would make it easier to have portBLAS used as a fallback. The fallback feature won't happen in this PR but I think we will likely want to remove this option in the future so might as well not add it.
I think we could have portBLAS always use the generic device as part of this PR as well.
| @@ -59,11 +59,19 @@ inline oneapi::mkl::device get_device_id(sycl::queue &queue) { | |||
| else if (vendor_id == AMD_ID) | |||
| device_id = device::amdgpu; | |||
| else { | |||
| #ifdef ENABLE_GENERIC_DEVICE | |||
There was a problem hiding this comment.
It seems to me we could avoid these ifdef and always return a generic_device as a fallback. The table_initializer object should throw backend_not_found the generic_device is used with a backend that does not support it.
|
Closing in favor of #566 |
Description
Relates to When trying to use oneMKL with the portBLAS backend there is a check for Intel, AMD or Nvidia GPU. #542
Checklist
All Submissions
New features