Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo docs, update crate to version 0.3.0 for publishing #20

Merged
merged 5 commits into from
Oct 5, 2023

Conversation

boydgreenfield
Copy link
Contributor

@boydgreenfield boydgreenfield commented Oct 5, 2023

There's currently an issue with mmap-bitvec pointer dereferencing for 1.70+, which seems to relate to this change in rust 1.70:

Insert alignment checks for pointer dereferences as debug assertions This catches undefined behavior at runtime, and may cause existing code to fail.

(And here's another related issue). We'll need to:

  • Fix this in mmap-bitvec
  • Add a regression test (tests there pass just fine...)
  • Release a new mmap-bitvec
  • Update the dependency here

@GSGerritsen I know you're out, but FYI I may have to ping you to add me on Cargo in order to publish a new version of mmap-bitvec because I believe you're the only one with keys (maybe @Keats you have those too?).

@boydgreenfield boydgreenfield force-pushed the boyd/docs-updates-for-publishing branch 5 times, most recently from 3bde349 to 87190b6 Compare October 5, 2023 19:16
@boydgreenfield boydgreenfield changed the title Update cargo docs, update crate to version 0.3.0 for publishing [REQUIRES AN UPSTREAM FIX] Update cargo docs, update crate to version 0.3.0 for publishing Oct 5, 2023
@boydgreenfield boydgreenfield force-pushed the boyd/docs-updates-for-publishing branch from 08ab537 to 4c80228 Compare October 5, 2023 19:33
@boydgreenfield
Copy link
Contributor Author

OK y'all already have a PR opened. 🤦‍♂️ onecodex/mmap-bitvec#20

Adding a regression test there and will work to get everything merged in and packaged up.

@boydgreenfield boydgreenfield force-pushed the boyd/docs-updates-for-publishing branch from 8925cfb to 047aaee Compare October 5, 2023 21:46
@boydgreenfield boydgreenfield changed the title [REQUIRES AN UPSTREAM FIX] Update cargo docs, update crate to version 0.3.0 for publishing Update cargo docs, update crate to version 0.3.0 for publishing Oct 5, 2023
@boydgreenfield boydgreenfield force-pushed the boyd/docs-updates-for-publishing branch from 1e4cb88 to 88bc3a7 Compare October 5, 2023 21:49
@boydgreenfield boydgreenfield merged commit d131df2 into main Oct 5, 2023
4 checks passed
@boydgreenfield boydgreenfield deleted the boyd/docs-updates-for-publishing branch October 5, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant