Add verification tool for evm offchain replay #6755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added websocket controller * Added mock block provider * Added data provider factory * Added websocket handler * Added websocket config * Added a tiny POC test for websocket handler
* Use contexts as function arguments * Move models to folder for consistency * Change parse msg function * Simplify mock block provider to remove dedlock
* make handle_connection blocking * rename concurrent_map * use type switch instead of switch * add todos for error handling
update height in comment
…handler [Access] Add new websocket handler and skeleton for its deps
zhangchiqing
changed the base branch from
master
to
leo/add-testcase-for-offchain-evm-backward-compatibilities
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## leo/add-testcase-for-offchain-evm-backward-compatibilities #6755 +/- ##
==============================================================================================
+ Coverage 41.23% 41.34% +0.10%
==============================================================================================
Files 2054 1966 -88
Lines 182383 173879 -8504
==============================================================================================
- Hits 75212 71888 -3324
+ Misses 100869 95958 -4911
+ Partials 6302 6033 -269
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
zhangchiqing
force-pushed
the
leo/add-verify-evm-offchain-replay
branch
from
103f257
to
d379a68
Compare
| return nil | ||
| } | ||
|
|
||
| func parseEVMEvents(evts flow.EventsList) (*events.BlockEventPayload, []events.TransactionEventPayload, error) { |
There was a problem hiding this comment.
This does not seem to handle the case where there was a period that did not have blocks executed events, but did have transaction executed.
The solution is to accumulate the transaction executed events, until you hit the next block executed event.
| return nil | ||
| } | ||
|
|
||
| func initStorages(chainID flow.ChainID, dataDir string, executionDataDir string) ( |
There was a problem hiding this comment.
chain ID is not needed
zhangchiqing
force-pushed
the
leo/add-verify-evm-offchain-replay
branch
from
6b36eb7
to
c43fc02
Compare
Add offchain block context creation method
zhangchiqing
force-pushed
the
leo/add-verify-evm-offchain-replay
branch
from
8f6ed3b
to
5db925d
Compare
zhangchiqing
force-pushed
the
leo/add-testcase-for-offchain-evm-backward-compatibilities
branch
from
4fe749e
to
27c0f3a
Compare
zhangchiqing
force-pushed
the
leo/add-verify-evm-offchain-replay
branch
from
a725780
to
f564161
Compare
Merged
zhangchiqing
force-pushed
the
leo/add-testcase-for-offchain-evm-backward-compatibilities
branch
from
27c0f3a
to
0cfcb7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a util cmd for verifying the evm offchain replay