🐛 Make the work feedback rule jaonpath name unique #346
Conversation
Signed-off-by: zhujian <[email protected]>
|
/hold |
work/v1/types.go
Outdated
| @@ -94,6 +94,8 @@ type ManifestConfigOption struct { | |||
|
|
|||
| // FeedbackRules defines what resource status field should be returned. If it is not set or empty, | |||
| // no feedback rules will be honored. | |||
| // +listType:=map | |||
| // +listMapKey:=type | |||
There was a problem hiding this comment.
Here, I am not sure if we should treat the type as the map key, if we do, If we do this, it may be incompatible, but if we do not, users can still configure two same name jsonpaths:
feedbackRules:
- type: JSONPaths
jsonPaths:
- name: "Replica"
path: .spec.replicas
- type: JSONPaths
jsonPaths:
- name: "Replica"
path: .status.replicas
@qiujian16 @zhiweiyin318 WDYT?
There was a problem hiding this comment.
let's do name at first...I am not sure if anyone uses multiple jsonPaths today, not quite likely.
Signed-off-by: zhujian <[email protected]>
Signed-off-by: zhujian <[email protected]>
zhujian7
force-pushed
the
feedbackrule
branch
from
cc5a26a to
ab3be60
Compare
|
/assign @qiujian16 @zhiweiyin318 |
zhujian7
force-pushed
the
feedbackrule
branch
from
d571742 to
5ca665c
Compare
Signed-off-by: zhujian <[email protected]>
zhujian7
force-pushed
the
feedbackrule
branch
from
5ca665c to
1c411c6
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-merge-bot
bot
merged commit cb7ce98
into
open-cluster-management-io:main
Summary
Related issue(s)
Fixes #