Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Deprecate managedserviceaccount v1alpha1 #92

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Jan 2, 2024

Summary

  • Deprecate managedserviceaccount v1alpha1
  • Change the managedserviceaccount API storage version from v1alpha1 to v1beta1

Related issue(s)

#77

Fixes #

@openshift-ci openshift-ci bot requested review from qiujian16 and yue9944882 January 2, 2024 09:36
@openshift-ci openshift-ci bot added the approved label Jan 2, 2024
@zhujian7 zhujian7 changed the title Deprecate managedserviceaccount v1alpha1 🌱 Deprecate managedserviceaccount v1alpha1 Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (051c36f) 81.59% compared to head (1eefef3) 81.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   81.59%   81.59%           
=======================================
  Files           5        5           
  Lines         402      402           
=======================================
  Hits          328      328           
  Misses         58       58           
  Partials       16       16           
Flag Coverage Δ
unit 81.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
to confirm: we need to migration in the next release?

Copy link

openshift-ci bot commented Jan 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6b87ce3 into open-cluster-management-io:main Jan 3, 2024
12 checks passed
haoqing0110 pushed a commit to haoqing0110/managed-serviceaccount that referenced this pull request Jun 6, 2024
Signed-off-by: red-hat-konflux <123456+red-hat-konflux[bot]@users.noreply.github.com>
Co-authored-by: red-hat-konflux <123456+red-hat-konflux[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants